documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Found five hooks API missed in doc, and one is invalid

Open ddb4github opened this issue 4 years ago • 3 comments

In Plugin-Hook-API-Ref

  • Missed: device_threshold_autocreate, expand_title, is_device_in_maintenance, custom_2fa_login, utilities_tab
  • Invalid: report_filter link is broken. Also, report_filter is not found in any code(both of 1.2.x and develop branch)

As soon, I'll create a PR for new custom_denied, auth_profile_xxx since 1.2.0-beta3, and device_xxxx in develop branch

ddb4github avatar Apr 18 '20 13:04 ddb4github

@ddb4github wasn't there a PR done for this? #73 I believe?

netniV avatar May 31 '20 08:05 netniV

@ddb4github wasn't there a PR done for this? #73 I believe?

No I'm not sure the desc of device_threshold_autocreate, expand_title, is_device_in_maintenance, and custom_2fa_login. Also not sure delete report_filter or keep.

BTW, custom_2fa_login is more like 'develop' branch API, not for '1.2.x'

So I just update utilities_tab and some other API in #73

ddb4github avatar May 31 '20 23:05 ddb4github

It is and should have 1.3 as its version introduced. The documentation is not version dependant at the moment because it would be too much work. If we include any version specific features, these should be tagged in the text to say when it is available or working from.

netniV avatar Jun 01 '20 23:06 netniV