cacti icon indicating copy to clipboard operation
cacti copied to clipboard

Data Query paths use XML tag

Open netniV opened this issue 3 years ago • 3 comments

Describe the bug

To specify the root path for cacti, data queries use <path_cacti> as part of the xml filename. However, when exported, this makes any XML document invalid as it does not have a closing tag. Either the value should be updated to be <path_cacti /> or changed to match other replacement fields such as |path_cacti|

To Reproduce

$ xmllint --format template.xml
template.xml:5: parser error : Opening and ending tag mismatch: path_cacti line 5 and xml_path
<xml_path><path_cacti>/plugins/mURLin/xml/mURLin.xml</xml_path>
                                                               ^
template.xml:148: parser error : Opening and ending tag mismatch: xml_path line 5 and hash_040102e404254402722ff686605143fb5a2f93
</hash_040102e404254402722ff686605143fb5a2f93>
                                              ^
template.xml:1372: parser error : Opening and ending tag mismatch: hash_040102e404254402722ff686605143fb5a2f93 line 5 and cacti
</cacti>
        ^
template.xml:1372: parser error : EndTag: '</' not found
</cacti>

netniV avatar Jun 28 '21 13:06 netniV

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 28 '21 00:08 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 31 '21 00:10 github-actions[bot]

Moving to enhancement to prevent the evil outdated bot from making us uncomfortable.

TheWitness avatar Dec 10 '21 19:12 TheWitness

@netniV, just update the template XML to change <path_cacti> to &lt;path_cacti&gt; it looks like that's simply a REAL OLD template from before we started escaping the <path_cacti>

TheWitness avatar Oct 16 '22 23:10 TheWitness