cacti icon indicating copy to clipboard operation
cacti copied to clipboard

Plugin dependency check during upgrade

Open netniV opened this issue 5 years ago • 4 comments

Is your feature request related to a problem? Please describe. When upgrading a plugin, you can easily upgrade to a version that requires a higher level of the core of cacti or dependency plugin without realising (see https://github.com/Cacti/plugin_thold/issues/261 as an example though others have come before it).

Describe the solution you'd like When a plugin's version no longer matches the INFO file, the dependencies should be checked and if not met, the plugin disabled with an email to the primary admin.

netniV avatar Feb 27 '19 09:02 netniV

Just generating a warning message and disabling will trigger the admin notification. Should be enough.

cigamit avatar Feb 28 '19 02:02 cigamit

@netniV, this is like the one remaining bug before 1.2.3. Are you working on it right now?

cigamit avatar Mar 07 '19 13:03 cigamit

I'm going to move this to 1.3 since it will be new functionality rather than fixing a bug as it has always been operating the existing way.

netniV avatar Mar 08 '19 09:03 netniV

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 28 '19 04:12 stale[bot]

Whilst looking into this, I think there is a problem with being able to implement it. The issue with this is that most plugins do their own handling of upgrade detection. the core knows nothing of this or that it is even occurring.

netniV avatar Nov 29 '22 00:11 netniV