angular-form-errors-directive icon indicating copy to clipboard operation
angular-form-errors-directive copied to clipboard

Bug "Too much recursion"

Open McGiogen opened this issue 8 years ago • 0 comments

There is a bug caused by a weak check using recursion to list all child forms errors in the same form-errors panel. We have encountered this because of angular-xeditable but I'm sure it's not the only case that can occur. The problem is simple: this directive search child forms between props not starting with dollar "$", but xeditable put some internal props starting with "_" which breaks the recursion. To solve this problem I've made a fork checking if the value of the property is an object before recursing.

McGiogen avatar Jun 13 '16 08:06 McGiogen