crypto-currencies-values-ext icon indicating copy to clipboard operation
crypto-currencies-values-ext copied to clipboard

Add custom currencies and more

Open ValBaturin opened this issue 7 years ago • 4 comments

Hi and thank you for the extension. It's slow. Do you mind to implement something like cache? GBP and EUR is not necessary in cryptomarkets but BTC price is a must (i.e. ETH/BTC). Everybody wonders about Ripple, so where is XRP? But to be real it would be great to have an ability to choose the exact currencies. Best wishes

ValBaturin avatar Jan 04 '18 20:01 ValBaturin

Hi @ValeryBaturin ,

thanks a lot for your support, I appreciate.

It's slow

What do you mean? Is it slow on the bootstrap (when you open it)? Should I implement cache to improve performance speed for you?

GBP and EUR is not necessary for cryptomarkets but BTC price is a must (i.e. ETH/BTC). Everybody wonders about Ripple, so where is XRP?

This first version supports only the cryptocurrencies available on Coinbase. I'm writing a readable roadmap in the README that includes:

  • Integration of new exchange APIs
  • Capability to filter by available CC
  • Capability to sort/order CC

I really appreciate your questions and support. Thank you again 👍

CVarisco avatar Jan 04 '18 20:01 CVarisco

I published a new version (v0.0.2) where the speed on the startup should be improved (if slow now, is because the API is slow). And also, now the order is always the same.

Tell me if do you like it and if there will be other issues 👍

CVarisco avatar Jan 05 '18 07:01 CVarisco

Thank you for the fast update! It's slow in terms of use cases. And it's still slow. The use case is sometimes to check crypto currency prices. And I want prices to be ready when I click on the icon. From what I can feel it's already implemented a kind of memory or cache because when I click 2 time in a row, the second click goes smoothie. The idea is to update this state of memory on a regular basis so customers/users never need to wait. For example every 1 min. It could bring better experience compared to "go to coinbase and check manually".

ValBaturin avatar Jan 06 '18 21:01 ValBaturin

Hi @ValeryBaturin !

And I want prices to be ready when I click on the icon.

The API response time for the first time is the problem here. The cache that you propose is already implemented by the API because as you can see the price doesn't change every time that you open the extension (and the speed of response decrease a lot).

It's slow in terms of use cases.

With the order improvements, the capability to the user to look very fast the price that he wants to check is very good now.

I hope that I explain better what happens on the extension 🙂

CVarisco avatar Jan 09 '18 08:01 CVarisco