gtfs-realtime-validator icon indicating copy to clipboard operation
gtfs-realtime-validator copied to clipboard

Add "About" menu in webapp

Open barbeau opened this issue 7 years ago • 3 comments

Summary:

In the upper-right corner of the landing page, we have "About" menu option that currently doesn't do anything when clicked.

image

We need to fill this in. For "About", I'd like it to be a small drop-down that includes the Maven version number of the build and the Git commit ID for the head commit on which it was built.

Steps to reproduce:

Go to landing website page

Expected behavior:

Be able to find out more in "About" menu item by clicking on it

Observed behavior:

Nothing happens when you click on it

barbeau avatar Oct 25 '17 21:10 barbeau

@barbeau do you want the Maven version number of the build and the Git commit ID for the head commit fetched 'dynamically' for each build? or manually fetch from any particular location?

Suryakandukoori avatar Nov 01 '17 07:11 Suryakandukoori

@Suryakandukoori I'd prefer to have it fetched dynamically on each build (e.g., for Maven pull it from pom.xml and the <version> tag) so we don't have to manually change it.

I'm going to be committing the changes for https://github.com/CUTR-at-USF/gtfs-realtime-validator/pull/295 today, so you might want to hold off working on this until I finish that as the file locations will change and you'd be pulling from the submodules instead of one pom.xml.

So, after https://github.com/CUTR-at-USF/gtfs-realtime-validator/pull/295 is merged, the project will have two submodules:

  • gtfs-realtime-validator-lib, in the gtfs-realtime-validator-lib folder
  • gtfs-realtime-validator-webapp, in the gtfs-realtime-validator-webapp folder

For this issue, we'd need to pull the version for both of these, as they can be versioned separately.

barbeau avatar Nov 01 '17 13:11 barbeau

@Suryakandukoori Ok, I just merged https://github.com/CUTR-at-USF/gtfs-realtime-validator/pull/295, so you can continue doing this without any conflicts now.

barbeau avatar Nov 01 '17 17:11 barbeau