OpenTripPlanner-for-Android icon indicating copy to clipboard operation
OpenTripPlanner-for-Android copied to clipboard

Published 20 hours ago • verified publisher icon CUTR-at-USF

WIP - Review changes from https://github.com/Wacken88/HSL-OTP-for-Android

Open barbeau opened this issue 9 years ago • 4 comments

From @Wacken88:

so we implemented some features for exporting all kinds of information or for using Street View from the map. Additionally, there is a proof of concept favorites system and a widget to launch the app from the homescreen. Some parts of our implementation require a slightly higher Android version though. Unfortunately, we have been assigned to a new project now so that we probably will not work on it anymore.

Nevertheless, I put our last dev version to GitHub: https://github.com/Wacken88/HSL-OTP-for-Android ...You can try the application yourself and of course also diff the source code with the official OTP app repo. Our version is based on March 9 if I am not mistaken.

I've pulled the diff of the two projects into this PR so we can review and see if we can merge some of these changes into the main OTP Android project.

Thanks @Wacken88!

barbeau avatar May 06 '15 19:05 barbeau

Wow, sounds great to see more development on the app! :-)

Let's see if I can find some time to try to correct my changes to see if that solves the problem. El 6/5/2015 9:53 p. m., "Sean Barbeau" [email protected] escribió:

From @Wacken88 https://github.com/Wacken88:

so we implemented some features for exporting all kinds of information or for using Street View from the map. Additionally, there is a proof of concept favorites system and a widget to launch the app from the homescreen. Some parts of our implementation require a slightly higher Android version though. Unfortunately, we have been assigned to a new project now so that we probably will not work on it anymore.

Nevertheless, I put our last dev version to GitHub: https://github.com/Wacken88/HSL-OTP-for-Android...You can try the application yourself and of course also diff the source code with the official OTP app repo. Our version is based on March 9 if I am not mistaken.

I've pulled the diff of the two projects into this PR so we can review and see if we can merge some of these changes into the main OTP Android project.

Thanks @Wacken88 https://github.com/Wacken88!

You can view, comment on, or merge this pull request online at:

https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471 Commit Summary

  • Changes from https://github.com/Wacken88/HSL-OTP-for-Android

File Changes

  • M .gitignore https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-0 (2)
  • M opentripplanner-android/build.gradle https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-1 (4)
  • M opentripplanner-android/src/main/AndroidManifest.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-2 (55)
  • M opentripplanner-android/src/main/java/edu/usf/cutr/opentripplanner/android/MyActivity.java https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-3 (85)
  • M opentripplanner-android/src/main/java/edu/usf/cutr/opentripplanner/android/OTPApp.java https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-4 (33)
  • M opentripplanner-android/src/main/java/edu/usf/cutr/opentripplanner/android/fragments/DirectionListFragment.java https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-5 (160)
  • M opentripplanner-android/src/main/java/edu/usf/cutr/opentripplanner/android/fragments/MainFragment.java https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-6 (304)
  • M opentripplanner-android/src/main/java/edu/usf/cutr/opentripplanner/android/util/CustomAddress.java https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-7 (4)
  • M opentripplanner-android/src/main/java/edu/usf/cutr/opentripplanner/android/util/CustomInfoWindowAdapter.java https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-8 (8)
  • M opentripplanner-android/src/main/java/edu/usf/cutr/opentripplanner/android/util/PlacesAutoCompleteAdapter.java https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-9 (25)
  • D opentripplanner-android/src/main/java/edu/usf/cutr/opentripplanner/android/util/RightDrawableOnTouchListener.java https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-10 (66)
  • M opentripplanner-android/src/main/res/drawable-hdpi/ic_launcher.png https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-11 (0)
  • M opentripplanner-android/src/main/res/drawable-mdpi/ic_launcher.png https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-12 (0)
  • M opentripplanner-android/src/main/res/drawable-xhdpi/ic_launcher.png https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-13 (0)
  • M opentripplanner-android/src/main/res/drawable-xxhdpi/ic_launcher.png https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-14 (0)
  • M opentripplanner-android/src/main/res/drawable-xxxhdpi/ic_launcher.png https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-15 (0)
  • M opentripplanner-android/src/main/res/layout-land-ldpi-v14/main.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-16 (21)
  • M opentripplanner-android/src/main/res/layout-land-ldpi/main.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-17 (21)
  • M opentripplanner-android/src/main/res/layout-land-v14/main.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-18 (21)
  • M opentripplanner-android/src/main/res/layout-land/main.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-19 (21)
  • M opentripplanner-android/src/main/res/layout-ldpi-v14/main.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-20 (23)
  • M opentripplanner-android/src/main/res/layout-ldpi/main.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-21 (22)
  • M opentripplanner-android/src/main/res/layout-v14/main.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-22 (23)
  • M opentripplanner-android/src/main/res/layout/list_direction_header.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-23 (22)
  • M opentripplanner-android/src/main/res/layout/main.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-24 (21)
  • M opentripplanner-android/src/main/res/raw/googleplaceskey.txt https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-25 (2)
  • M opentripplanner-android/src/main/res/values-de/strings.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-26 (17)
  • M opentripplanner-android/src/main/res/values-es/strings.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-27 (15)
  • M opentripplanner-android/src/main/res/values-fr/strings.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-28 (20)
  • M opentripplanner-android/src/main/res/values-gl/strings.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-29 (16)
  • M opentripplanner-android/src/main/res/values-it/strings.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-30 (15)
  • M opentripplanner-android/src/main/res/values-pt/strings.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-31 (15)
  • M opentripplanner-android/src/main/res/values-ro/strings.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-32 (15)
  • M opentripplanner-android/src/main/res/values/colors.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-33 (1)
  • M opentripplanner-android/src/main/res/values/donottranslate.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-34 (4)
  • M opentripplanner-android/src/main/res/values/strings.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-35 (34)
  • M opentripplanner-android/src/main/res/values/styles.xml https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471/files#diff-36 (8)

Patch Links:

https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471.patch

https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471.diff

— Reply to this email directly or view it on GitHub https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/471.

vreixo avatar May 06 '15 19:05 vreixo

@Wacken88 @barbeau @vreixo : trying to build the app after merging this pull request, I encounter the following error:

/home/nicolas/packaging/sources/OpenTripPlanner-for-Android/opentripplanner-android/build/intermediates/manifests/full/debug/AndroidManifest.xml:136:35-46 : No resource found that matches the given name (at 'resource' with value '@xml/widget').

an idea why?

kalon33 avatar Oct 14 '15 23:10 kalon33

I don't recall if this diff builds or not - at the time I was more focused on capturing the changes so we could review at a later date.

Looking at the above comments, I'm guessing the build fails because they were requiring a higher Android versions than us.

barbeau avatar Oct 14 '15 23:10 barbeau

@barbeau I kept the version changes and tried to build against API 22 when getting this error.

kalon33 avatar Oct 15 '15 09:10 kalon33