Problems with strings displaying server info

[vreixo]

I have found that in actual master, in 4.1.2, when a server is offline, there is a problem with the message. Instead of displaying: Offline: Not it says Offline: Cancel.

This is happening, at least, in Spanish, Galician and English. I suppose that is a problem with Android resources, because what is used is android.R.string.no and android.R.string.cancel also exists. If this is a general problem we can use again custom strings for this (in fact I think that I would be able to take them in all the languages from previous versions of the files).

Another problem is that the message attached to the exception, if there is an error trying to reach the server, is not null-checked, so the error toast might display Unable to contact region: null.

[kalon33]

@vreixo That happens in French too, I was looking for that string to correct it in the translation but didn't found it.

[vreixo]

@kalon33, thanks for the catch!

The problem is that we are using a system wide string to avoid adding unnecessary strings to our highly populated values files. The problem is that the string chosen seems that is clearly not the correct one, also in French, although it seemed to be adequate judging by the name.

You can see here how the string is called with android prefix, which is what defines that this is a system wide resource and not one defined in our project.

The possible solutions are to find a matching resource or, if there isn't any, to define a new string in the proper section of values for all the languages supported.