andes icon indicating copy to clipboard operation
andes copied to clipboard

WTDTA1 Htfrac is set to be ``power`` based

Open jinningwang opened this issue 8 months ago • 1 comments

Describe the bug

WTDTA1 Htfrac should be a fraction, rather than power-based

https://github.com/CURENT/andes/blob/ce1a5124042aa5db3cfab6e64f18bb575908aa53/andes/models/renewable/wtdta1.py#L32-L36

To Reproduce

Update data files and code for reproducing the error.

If you need to insert code inline, use a pair of triple backticks to format:

```python
Code goes here
```

Expected behavior

A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • ANDES version (please paste the output from andes misc --version)

**pip packages (please paste the output from pip list)

Additional context

Add any other context about the problem here.

jinningwang avatar Apr 22 '25 19:04 jinningwang

@cuihantao

Hantao, I developed this example to justify my point, https://github.com/CURENT/demo/blob/master/demo/misc/WTDTA1.ipynb

My points:

  1. WTDTA1.Hfrac should not set power=True
  2. I feel it is worth investigating potential modeling errors in WTDTA1

What do you think about it?

jinningwang avatar Apr 23 '25 00:04 jinningwang