yoyodyne
yoyodyne copied to clipboard
Embeddings not being passed to lstm module
For some reason, someone added an embeddings
argument to BaseModule
but didn't update the other modules to pass it.
Why are we passing embeddings as an argument? Those should be an attribute of the model class.