cheribuild icon indicating copy to clipboard operation
cheribuild copied to clipboard

Add --presume-connectivity option

Open nwf-msr opened this issue 2 years ago • 3 comments

If we're heavily firewalled, the attempt to check whether we're online doesn't really indicate whether or not we'll be able to reach, for example, github.com . Operating in such an environment, I have historically just stubbed out the test locally, but rather than continuing to do that, having an option could be nice.

nwf-msr avatar Nov 02 '22 03:11 nwf-msr

I don't think the CI failure is my fault, as it shows up in #311, too. It looks like df90883bdc2ef8f726d4e8fbd5abdf1a2da79e51 removed the # noinspection PyTypeChecker directive from add_bool_option when it moved the function from project.py to simple_project.py?

nwf-msr avatar Nov 02 '22 03:11 nwf-msr

I don't think the CI failure is my fault, as it shows up in #311, too. It looks like df90883 removed the # noinspection PyTypeChecker directive from add_bool_option when it moved the function from project.py to simple_project.py?

Should hopefully be fixed now

arichardson avatar Nov 14 '22 07:11 arichardson

This seems okay to me although I do wonder if there is a better check that also succeeds in your environment?

Hitting github.com:443 is probably a fine test?

I also wonder if we should assume the same for ssh_host_accessible, although that is more questionable?

I haven't tripped over that one yet.

nwf avatar Nov 14 '22 15:11 nwf