cheribuild icon indicating copy to clipboard operation
cheribuild copied to clipboard

docker image: switch to a new non-root user when started as root

Open arichardson opened this issue 3 years ago • 3 comments

Instead of manually adding a matching user with the docker-adduser cheribuild target, this adds an ENTRYPOINT script to the docker image that automatically creates an unprivileged user. The UID/GID/name can be passed using environment variables (-e flag to docker run).

arichardson avatar Sep 07 '21 14:09 arichardson

I believe this should now be correct.

arichardson avatar Sep 10 '21 11:09 arichardson

My only concern with merging this is that the initial release tarball (which we know some people are using) failed to check out a tag for cheribuild, so it tracks master and prompts people to update, meaning we can't actually make the cheribuild side of the necessary changes to support this because that will break with people's existing docker images. I don't know how we deal with that though because it'll need breaking at some point, and other changes to cheribuild may stop things working with the release's snapshot of repos before then...

jrtc27 avatar Sep 10 '21 11:09 jrtc27

Yes that is unfortunate. However, these dockerfile changes should be backwards compatible since they do nothing when --uid is passed to docker.

I'll look into a workaround for the release when I actually make the docker commandline change.

arichardson avatar Sep 10 '21 13:09 arichardson