cheribsd icon indicating copy to clipboard operation
cheribsd copied to clipboard

psci: Make the assembly code match the structure defined in C

Open arichardson opened this issue 2 years ago • 2 comments

The output argument is a struct containing uintptr_t, so we should be storing capabilities there and not integers. Alternatively, the struct should be changed to always use ptraddr_t.

arichardson avatar May 14 '22 20:05 arichardson

Noticed this before but IIRC nothing passes non-NULL for the 9th argument so in practice it's dead code (other than the load from the stack, which works due to endianness). Worth fixing though.

jrtc27 avatar May 14 '22 20:05 jrtc27

The struct probably should be register_t though to match the argument types until such time as PSCI gains a capability-aware interface (which changes almost nothing except for CPU_ON, IIRC)

jrtc27 avatar May 14 '22 20:05 jrtc27

Fix has been merged.

arichardson avatar Jul 12 '23 23:07 arichardson