Ossian
Ossian copied to clipboard
Change Processor File / class names
Hi Oliver et al,
I was looking up some things on SKLDecisionTreePausePredictor
, because the SKL
part wasn't obvious to me. Then I saw it's sci-kit learn, and that there's a file called SKLProcessors.py
with other processors built on sci-kit learn.
I suggest the SKL
be removed from class and file names, to make things more transparent.
In general, it seems that the *.py
scripts in $OSSIAN/scripts/processors/*
are one processor per file. (e.g. PhraseMaker.py
, VSMTagger.py
, Syllabifier.py
).
SKLProcessors.py
deviates from this trend, with multiple processors contained in the one file. I suggest that some kind of standard for processors and their filenames be set.
Maybe stick with the one processor per python script?
Thoughts?
-josh