Carter Francis

Results 333 comments of Carter Francis

@magnunor Do you know why those tests are failing? This seems like a regression but maybe it wasn't tested before.

Once #1080 is merged do you want to rebase? If we figure out the testing I can take another pass through and then we can think about what it would...

> > Once #1080 is merged do you want to rebase? If we figure out the testing I can take another pass through and then we can think about what...

> I merged the current `main` branch into this branch. Yay > Running `BeamShift.plot()` on a dataset with `` units gives: > > ```python > WARNING | Hyperspy | Axes...

@magnunor do you have time to work on this or do you want me to give it a shot. On second thought I think the warnining is totally reasonable... People...

@magnunor I fixed the bug causing the tests to fail and adjusted some of the code. I think this is starting to look pretty good, the only thing I would...

@magnunor sounds good. I'm going to review the changes again. If you have time can you go over my additions? Then we can merge.

> In the past you would use the `to_beamshift` method which would do this for you. But is it good to maybe consider doing it automatically when sending in a...

@magnunor If you don't have time to get to this today I might try to make things a bit more backwards compatible and then merge.

Types of mask: (2D Signal masks) - get_azimuthal_integral1d --> Mask for ignoring pixels - get_direct_beam_mask --> Get a mask for the direct beam - find_dead_pixels --> mask certain pixels -...