Carter Francis
Carter Francis
> @CSSFrancis and @viljarjf These types of things I wrestled with extensively while I was implementing template matching and was trying it on my own data, and I also wrote...
Okay we are starting to get somewhere with this :) I might try to remake the g-phase tutorial as well. We should be able to create a polar mask and...
I'm going to clean this up a little bit today and then maybe we can think about merging this? It's starting to grow to an "unreviewable" size. It would be...
Okay any last comments before merging this @viljarjf?
> I suggested sign-posting to https://doi.org/10.1016/j.ultramic.2022.113517 because it has useful explanation on the approach used here. For sure, there will be other useful reference to add, but these can be...
I think this has been partially reviewed a couple of times along the way so I am going to merge it at the end of the day today unless there...
> The recent changes look good to me. I have not gotten around to trying them out yet, I'll try tomorrow but it might be merged by then @viljarjf I'll...
Just a note that this is going to make problems with #1018 I guess that one might have to wait a bit (however) as it depends on a new orix...
@magnunor I would rebase this based on PR that just got merged before you go too much further as that PR moves some things around. Let me know if you...
> Two points which would be nice to discuss: > > In this pull request, the `BeamShift.plot` function does this: > > ```python > def plot(self): > self.T.plot() > ```...