Carter Francis

Results 576 comments of Carter Francis

After looking through [ASE](https://wiki.fysik.dtu.dk/ase/index.html) as little more I wonder if it would be a good dependency. Could it be used to replace some of the places where diffpy is used...

> As far as I've seen it's mainly used to load CIF files and if I'm not mistaken also to construct reciprocal space grids. ASE is probably a more reliable...

> What does ASE offer that you need that diffpy.structure don't, @CSSFrancis? I agree that the package isn't optimal, but it is light weight, and I find their documentation and...

From #170 it seems like https://github.com/jacobjma/abTEM might be a good option. Either for handling multislice simulations or just to have handle all of the kinematic, and mulitslice simulations

@viljarjf I tried to start testing to make sure that the `Orientations` recovered are correct. Any chance you can look through this and figure out why the `Orientation` doesn't align...

> Template matching suffers from misindexation quite often, which is probably what is happening here. I tried replacing the random orientations of the grains with some easier zone axes, and...

@pc494 Any chance you can look this over? We can merge it once the new simualtions for diffsims are relased and maybe think about what it might take to make...

@viljarjf I've been playing around with this a little bit more. We can pretty easily do something like this: Which I think seems useful but this problem of misorientations is...

Just following up on this a little bit more: ```python from pyxem.data import si_phase, si_grains, si_rotations_line from diffsims.generators.simulation_generator import SimulationGenerator from orix.sampling import get_sample_reduced_fundamental import hyperspy.api as hs #simulated_si =...

> I read a master thesis that looked at the correlation score metric in pyxem and tried a couple different ones, but did not get any better results. The NCC...