Carter Francis
Carter Francis
@hakonanes sure it can be... What is the argument for not having it part of the RLV. How does kikchuipy use the `RLV `for doing simulations? Do you need to...
> I've got to think a bit on it. Quoting `python -c "import this"`: > > > Now is better than never. > > Although never is often better than...
> But do you need to rotate reciprocal lattice vectors for the tutorial? This "bug" was reported based on our discussions in #205, not by a user in a real...
@hakonanes I've looked at the kikuchipy simulation code and do you end up rotating the hkl vectors rather the xyz vectors?
@hakonanes @viljarjf both of these are solved by the PR to orix.
@viljarjf this would only work for Rotations with size==(1,) but that isn't really a huge issue as we already are creating seperate RLV for storing the simulation results.
@hakonanes Do you feel more comfortable with this? This doesn't change anything about the RLV; it only uses already existing attributes in the Lattice object.
We could always go back to the idea of saving the Rotation seperately and then applying the inverse rotation when calculating the hkl. It maybe isn't as elegant of a...
Thanks for all of the responses. I was kind of naive in my thinking, about how to better integrate pyxem and diffsims so I might give it a little more...
> Maybe you are already aware but if full scale diffraction simulations are of interest I think it is probably wisest to take a look at [abTEM](https://github.com/jacobjma/abTEM) and see whether...