Carter Francis

Results 333 comments of Carter Francis

> Sounds good. You're thinking of a release candidate on PyPI? Yea, it just makes it easier for testing in pyxem as we can just install the rc rather than...

@hakonanes I'll wait until the CI finishes and then merge then we can go ahead!

@hakonanes thank you so much for your help with this! I don't think we really want to do a pre-release on cond-forge (just sounds like a lot of work). As...

I think we can probably go ahead with this. I've been using this for a couple of weeks now with no issues so we can make the 0.6.0 release.

Should this even be possible? 1. The hkl value is not preserved 2. How do you handle multiple orations. Should that return multiple RLV (that is actually not ideal for...

@viljarjf The HKL is dependent on the RLV and the lattice. If we have a set of RLV and we rotate them (and don't rotate the lattice in some way)...

```python import diffpy import numpy as np from diffsims.crystallography import ReciprocalLatticeVector from orix.crystal_map import Phase from orix.quaternion import Rotation # Shared parameters latt = diffpy.structure.lattice.Lattice(2.464, 2.464, 6.711, 90, 90, 120)...

@hakonanes have you ever used the https://www.diffpy.org/diffpy.structure/mod_lattice.html `baserot` parameter. I think that we could have the rotation also rotate the lattice. That would at least allow us to rotate the...

@hakonanes This is partially fixed in https://github.com/pyxem/orix/pull/499. Proper HKL values requires some more thought and better handling.

@hakonanes So what I've come to is that it __should__ be possible to rotate the RLV as long as we can track the rotation. This allows us to have consistent...