RavenPy icon indicating copy to clipboard operation
RavenPy copied to clipboard
verified publisher icon CSHS-CWRA

Update notebooks to work with changes to dask chunking, adapt to new Raven code conventions

Open Zeitsperre opened this issue 1 year ago • 4 comments

Fixes 1/2 of https://github.com/Ouranosinc/pavics-jupyter-env-issues/issues/12

FYI @tlvu

Changes

  • Updates the date handling of datasets so that chunking with dask is properly performed
  • Minor fixes to comments (formatting, typos).

Zeitsperre avatar Sep 20 '24 21:09 Zeitsperre

Please let me do the merge of this PR when it will be ready. This PR can only be merged at the same time the new Jupyter env is live.

tlvu avatar Sep 23 '24 17:09 tlvu

@tlvu For this PR, feel free to ignore the failing tests and use your admin rights to bypass the protections. The code changes here are ready and shouldn't break things in production, from what I can tell.

If I can get the other PRs here approved, tests should pass without problems.

Zeitsperre avatar Sep 23 '24 18:09 Zeitsperre

Coverage Status

coverage: 81.352%. remained the same when pulling c06bf1fd5901a1547b78ee3a41a96e0c2e7b09c9 on fix-pjei-12 into 88bfc6f3af3082206d89ddadb3ca0afa68513b1e on master.

coveralls avatar Oct 01 '24 19:10 coveralls

The other PR https://github.com/CSHS-CWRA/RavenPy/pull/406 has been merged into this PR.

tlvu avatar Oct 08 '24 21:10 tlvu