RavenPy icon indicating copy to clipboard operation
RavenPy copied to clipboard
verified publisher icon CSHS-CWRA

RavenGIS

Open Zeitsperre opened this issue 4 years ago • 3 comments

Overview

This PR fixes [issue id]

Changes:

  • Refactoring of the GIS utilities found in RavenPy into its own project

Related Issue / Discussion

https://github.com/CSHS-CWRA/RavenPy/issues/125

Additional Information

Links to other issues or sources.

Zeitsperre avatar Aug 05 '21 21:08 Zeitsperre

Present state of affairs: Tests are passing, but the speed of tests test_generate_grid_weights_with_shp_input and test_generate_grid_weights_with_weight_rescaling is really slow. I imagine there are some optimizations that need to be worked out. Besides those, speed is comparable to GDAL implementations. Will begin cleaning up the PR here now.

Zeitsperre avatar Aug 10 '21 18:08 Zeitsperre

There's a very real possibility that the code will run faster without GDAL. I have some optimizing left to do, but I think the slowdowns in the GridWeight file formatter can be fixed with a cleaner approach. The original version of the code is triggered automatically if geopandas is installed (which depends on GDAL).

Zeitsperre avatar Aug 18 '21 14:08 Zeitsperre

I can't explain why the PyPI-noGDAL-based install is incredibly slow on some tests. The conda-forge build does not have GDAL and outperforms PyPI-GDAL builds by minutes. In any case, I need to move on for now,

Zeitsperre avatar Aug 19 '21 13:08 Zeitsperre