react-firebase-hooks icon indicating copy to clipboard operation
react-firebase-hooks copied to clipboard

Error in documentation of useSignInWithEmailAndPassword

Open a-barbieri opened this issue 3 years ago • 1 comments

https://github.com/CSFrequency/react-firebase-hooks/blob/edab3f3f3b5ec01c8aafcc6096755dfcc69e4408/auth/README.md?plain=1#L150

In the docs you use user.email but useSignInWithEmailAndPassword returns UserCredential type not User. The correct use should be user.user.email. It might be good to rename it then...

a-barbieri avatar May 19 '22 09:05 a-barbieri

The same goes for useCreateUserWithEmailAndPassword

a-barbieri avatar May 19 '22 16:05 a-barbieri

Thanks @a-barbieri, I have updated the documentation

chrisbianca avatar Nov 04 '22 16:11 chrisbianca