tket2 icon indicating copy to clipboard operation
tket2 copied to clipboard

feat: Add badgerv2_unstable feature, RewriteSpace and CommitFactory

Open lmondada opened this issue 6 months ago • 2 comments

This requires https://github.com/CQCL/hugr/pull/2349 and https://github.com/CQCL/hugr/pull/2402 to be merged in, as well as a breaking hugr release before it can be merged.

lmondada avatar Jun 24 '25 09:06 lmondada

Codecov Report

Attention: Patch coverage is 23.50746% with 410 lines in your changes missing coverage. Please review.

Please upload report for BASE (lm/hugr-v21@2ac9eed). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tket2/src/rewrite_space/max_sat.rs 0.00% 92 Missing :warning:
tket2/src/rewrite_space/factory/commute_cz.rs 42.94% 89 Missing :warning:
tket2/src/rewrite_space.rs 0.00% 86 Missing :warning:
tket2/src/rewrite_space/factory/explore.rs 35.65% 74 Missing :warning:
tket2/src/rewrite_space/factory.rs 21.42% 44 Missing :warning:
tket2/src/rewrite_space/factory/boxed.rs 19.35% 25 Missing :warning:
Additional details and impacted files
@@              Coverage Diff               @@
##             lm/hugr-v21     #928   +/-   ##
==============================================
  Coverage               ?   76.61%           
==============================================
  Files                  ?       98           
  Lines                  ?    11709           
  Branches               ?    11435           
==============================================
  Hits                   ?     8971           
  Misses                 ?     2119           
  Partials               ?      619           
Flag Coverage Δ
python 81.75% <ø> (?)
rust 76.49% <23.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 24 '25 09:06 codecov[bot]

After trying out a lot of approaches, I've chosen to pull the z3 compiled libraries from the z3 GitHub release (rather than asking the user to install it system-wide, or compiling them from scratch).

This required changes to the z3-sys crate. I've created a pull request on that project to merge in these changes, but for the time being I suggest we pull z3 from my fork.

z3-sys pull request: https://github.com/prove-rs/z3.rs/pull/352 z3 releases: https://github.com/Z3Prover/z3/releases

lmondada avatar Jul 04 '25 08:07 lmondada