Corona-tracker icon indicating copy to clipboard operation
Corona-tracker copied to clipboard

Added the trans tag with the required i18nKey

Open abhishekkumar08 opened this issue 4 years ago • 1 comments

⚠️ IMPORTANT: Please do not create a Pull Request without creating an Issue first.

All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.

Before submitting a pull request, please be sure to review:

  • Our Code of Conduct: https://github.com/COVID-19-electronic-health-system/.github/blob/master/CODE_OF_CONDUCT.md
  • Our Contributing Guidelines: https://github.com/COVID-19-electronic-health-system/.github/blob/master/CONTRIBUTING.md
  • Our Support documentation: https://github.com/COVID-19-electronic-health-system/.github/blob/master/SUPPORT.md

Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.

Fixes #726

Summary

Details

Test Plan (required)

Final Checklist

  • [ ] For CoronaTracker, did you bump the version in package.json?
    • Update the second decimal for a major change
    • Update the third decimal for a minor change
    • Numbers can go past 9, e.g. 1.0.9 => 1.0.10
    • For more info, read about Semantic Versioning
  • [ ] Did you add any new tests as necessary?
  • [ ] Is your PR rebased off the most current master?
  • [ ] Have you squashed all commits? (can be done at merge)
  • [ ] Did you use yarn not npm? (important!)
  • [ ] Did you use Material-UI wherever possible?
  • [ ] Did you run yarn lint on the code?
  • [ ] Did you run all of your most recent changes locally to make sure everything is working?

abhishekkumar08 avatar Aug 06 '20 06:08 abhishekkumar08

@thedeveloperhere I didn't review the code yet. But couple of things:

  1. Please follow the PR template and provide the asked info.
  2. If you did the above you would run the test locally and travis wouldn't fail 😁 Please run the test locally and follow the instructions, you might need to press u or r I dont recall, to make new snapshot for the test. Or you can delete the snaps manually "Don't recommend"

Thanks and good luck

AdhamAH avatar Aug 17 '20 07:08 AdhamAH