Corona-tracker icon indicating copy to clipboard operation
Corona-tracker copied to clipboard

[FEAT] Default translationValue to english value if empty

Open ngiangre opened this issue 4 years ago • 1 comments

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to consider/implement the feature.

Prerequisites

  • [ ] check this box if you have completed the following:
    • Reviewed the contributing guidelines and support files
    • Reviewed the README file for the repository you are working in
    • Searched for relevant instructions on our Discord server
    • Searched the issues of the repository you are working in to make sure one was not already filed

Summary

If the translation of text hasn't be added by a translator, the resulting value will be empty. In this case, the value should instead be the english value so that the key can be used by i18next while indicating there needs to be a translation of the text.

Motivation

When the app is in a non-english locale, there needs to be a translation provided and if not, a way to signal the translation needs to be added. This signal can be the text in english.

Possible Alternatives

Nothing shows up so debugging is more difficult.

Additional Context

pull_gsheets_translations_mvp.py needs to be updated with a conditional. If the translatedValue is empty, replace with the english value.

ngiangre avatar Jun 06 '20 22:06 ngiangre

I can work on this.

pavel-ilin avatar Jun 09 '20 14:06 pavel-ilin