Corona-tracker icon indicating copy to clipboard operation
Corona-tracker copied to clipboard

[FEAT] Add react-i18next tag to Cards components and page

Open AdhamAH opened this issue 4 years ago • 7 comments

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to consider/implement the feature.

Prerequisites

  • [x] check this box if you have completed the following:
    • Reviewed the contributing guidelines and support files
    • Reviewed the README file for the repository you are working in
    • Searched for relevant instructions on our Discord server
    • Searched the issues of the repository you are working in to make sure one was not already filed

Summary

Add <Trans/> tag with the related i18nKey in locales JSON files use the EN as it is the default

Motivation

Applying the translations

Possible Alternatives

no translations

Additional Context

AdhamAH avatar Jun 01 '20 21:06 AdhamAH

Hi @AdhamAH , I'll do this

gdemu13 avatar Jun 13 '20 15:06 gdemu13

Is the issue resolved? If not I want to work on this.

abhishekkumar08 avatar Jul 31 '20 03:07 abhishekkumar08

I don't know if @gdemu13 is still working on it? I think it has been for a while so wait a bit to see if @gdemu13 didn't answer then you can go ahead if you wish

AdhamAH avatar Jul 31 '20 09:07 AdhamAH

hi @AdhamAH, sorry didn't have time time to work on this issue. I don't mind if @thedeveloperhere wants to do it.

gdemu13 avatar Jul 31 '20 09:07 gdemu13

yeah okay. I would be pleased to do so. @AdhamAH @gdemu13

abhishekkumar08 avatar Jul 31 '20 09:07 abhishekkumar08

I have edited the files in pages folder. But I cant git commit is there a new thing, kindly help me with this.

abhishekkumar08 avatar Aug 03 '20 19:08 abhishekkumar08

@thedeveloperhere This article might be helpful: https://reflectoring.io/github-fork-and-pull/

KartikSoneji avatar Aug 04 '20 08:08 KartikSoneji