Corona-tracker icon indicating copy to clipboard operation
Corona-tracker copied to clipboard

[FEAT] Applying i18Next translations

Open AdhamAH opened this issue 4 years ago • 2 comments

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to consider/implement the feature.

Prerequisites

  • [x] check this box if you have completed the following:
    • Reviewed the contributing guidelines and support files
    • Reviewed the README file for the repository you are working in
    • Searched for relevant instructions on our Discord server
    • Searched the issues of the repository you are working in to make sure one was not already filed

Summary

Add the translation helper i18Next After PR #720 merges it will be easy to divide the work into separate issues depending on the page and components that related to it

Motivation

Showing the translated languages across the whole app

Possible Alternatives

None!

Additional Context

I will wait and see if there are any suggestions or ideas and start to open issues to execute

AdhamAH avatar May 18 '20 14:05 AdhamAH

@AdhamAH The helper function will get all language data from blockstack and then we will import data we need from this function, not from blockstack. Am I understand it correctly?

pavel-ilin avatar May 22 '20 13:05 pavel-ilin

That seems the case. I am not sure if there is another idea. I didn't really work with blockstack very much "which I should" or i18next. If from the helpers or blockstack, is there is a different how to add the translation to the components? I mean when using useTranslation or Trans if no different, then it doesn't matter if from helpers or blockstack. If there is a different then could you please explain a bit or point me to where I can get the info @pavel-ilin

AdhamAH avatar May 22 '20 23:05 AdhamAH