vehicle_signal_interface icon indicating copy to clipboard operation
vehicle_signal_interface copied to clipboard

Published 20 hours ago • verified publisher icon COVESA

README.md.api does not match vsi.c

Open chenbd opened this issue 6 years ago • 3 comments

Hello，

I read the document README.md.api but after I open the source files, seems the document not match with source. eg vsi_fire_signal in document but not in source.

Is this project still under development?

chenbd avatar Oct 27 '18 12:10 chenbd

It looks like that function is now named vsi_insert_signal.
If you want to you can edit README.md.api and propose a change to the documentation.

gunnarx avatar Oct 29 '18 08:10 gunnarx

OK, that did not feel right so I looked a bit closer. There was an incorrect comment in the header file that made me think it was the original "fire" function but of course that's not the case. Insert is a different operation and as the name suggests it is there to create a new signal in the database.

Apparently vsi_fire_signal was first commented out and later deleted in commit 818756f I think we have to ask the maintainer @dmiespdx what the situation is right now.

gunnarx avatar Oct 29 '18 10:10 gunnarx

I read the documents and i like the interface design. But is it better If the implementation be split as a client library and a daemon and IPC between them?

chenbd avatar Oct 31 '18 01:10 chenbd