COVESA
Extend search dialog to search by time
- fix some alignments in the dialog
- remove not useful "next"- and "previous"-buttons
- rename "save"-button into "ok"
https://github.com/COVESA/dlt-viewer/issues/730
The title of the Search Dialog is dlt-viewer. Can you change it to Search Settings? Additonal it would be good to have also a cancel button. Additional it would be good when ok is pressed the search is automatically restarted.
The title of the Search Dialog is dlt-viewer. Can you change it to Search Settings?
Good catch, thanks, I made the dialog's header look the same way as in master.
Additonal it would be good to have also a cancel button. Additional it would be good when ok is pressed the search is automatically restarted.
I did this, even though it is basically new feature on its own. What I do not like about "Cancel"-button is that my expectation upon cancel would be "no state changed", but this is not what happens: yes, there is a difference between "OK" and "Cancel", that the latter does not trigger search, however, search params are saved on every interaction (old behavior), which means "Cancel" does not prevent storing them in the persistent settings.