COVESA
Remove qmake project files.
@hannesa2 Can i remove this? Is qmake build necessary for MacOS?
C:\workspace\github\covesa\dlt-viewer\scripts\darwin\build_cmake.sh (2 hits) Line 17: qmake ../BuildDltViewer.pro Line 22: qmake ../BuildDltViewer.pro
is there anything missing for this PR to be merged? It is very nice if we would not need to maintain the qmake buildsystem anymore
@vifactor Still needed for the Debina build scripts
https://github.com/COVESA/dlt-viewer/blob/master/build_viewer_debs_noble.sh
@alexmucde I have hard time to find how this build script is used. Could you please point me to the place where qmake is invoked?
@vifactor Still needed for the Debina build scripts
https://github.com/COVESA/dlt-viewer/blob/master/build_viewer_debs_noble.sh
I'm somehow confused. The CI builds Ubuntu 24.04 and this script is not involved at all. For me this is a sign, that it's useless.
Same to https://github.com/COVESA/dlt-viewer/blob/master/build_viewer_debs.sh
To be honest, I would remove these files, to avoid to have to much non-supported (CI) build ways. https://github.com/COVESA/dlt-viewer/blob/master/build_viewer_debs_noble.sh https://github.com/COVESA/dlt-viewer/blob/master/build_viewer_debs.sh
It used by me for releasing the DLT Viewer, not by the CI buil.d system. I had no time yet to change them to cmake, so i want to keep them in.
The qmake call is there: https://github.com/COVESA/dlt-viewer/blob/master/noble/debian/rules
It used by me for releasing the DLT Viewer, not by the CI buil.d system.
Maybe in pre-continue-integration time, a manual release was required. But this has changed in 2023 ! In my point of view a manual release is no more required, and more then this: you should not release it manual again. With this background, the files are obsolete
@hannesa2 , Alex refers to a special so far manual release step dedicated for creation of the deb package for ubuntu. This is not automated in CI
In the mean time, I wonder if that step can simply be replaced by cmake call. Unfortunately, only @alexmucde can check and confirm
I tried already some time ago to switch to cmake for building Debian files, but this is not so easy. We need an additional target for cmake Linux, as it currently only works for Windows and Mac. I need the same target folder structure for cmake as for qmake today.
@vifactor If you have some time to work on it would be nice
@alexmucde I can look into it if you could be more precise on what to do. Is there a particular command that you run to create a deb on your local machine that I can repeat on mine?
This script is executed: https://github.com/COVESA/dlt-viewer/blob/master/build_viewer_debs_noble.sh This script builds the Debian for Ubuntu 24/04. This package configuration is used https://github.com/COVESA/dlt-viewer/tree/master/noble/debian. There you can find the qmake call which must be replaced by cmake https://github.com/COVESA/dlt-viewer/blob/master/noble/debian/rules. For cmake a new target must be defined to have another folder structure, similar to the structure for qmake.
Ubuntu Debian Build still fails, because still using qmake. Must switch to cmake first..
Ubuntu Debian Build still fails, because still using qmake. Must switch to cmake first..
I've started working on it, there were a couple of tricky issues, so it will take some more time. Hopefully not too much
Ubuntu Debian Build still fails, because still using qmake. Must switch to cmake first..
I've started working on it, there were a couple of tricky issues, so it will take some more time. Hopefully not too much
Thanks @vifactor for helping here. Possibly we need different cmake target configurations.
@vifactor I am using mainly QtCreator under Windows to develope and debug DLT Viewer. I tried yesterday with cmake only, but i had a lot of problems. I switched back to qmake. Which IDE are you using, expecially also for Debugging? Which OS? I would like to get rid of qmake, but with Qt Creator it does not work currently out of the box. QTCreator has some advantages, like the integrated UI Designer.
@alexmucde I also use qt creator mainly on ubuntu but also tried on win. Worked fine for me.