dlt-viewer icon indicating copy to clipboard operation
dlt-viewer copied to clipboard

Simplify handling of logging only mode in log table view

Open vifactor opened this issue 1 year ago • 3 comments

With this MR logging only mode is handled separately before any message decoding happens. Before this MR, although msg was default-assigned in one of the if-cases, it still was non-empty due to multiple decodings happening in the data-method for values of role-variable other than DisplayRole.

vifactor avatar Oct 21 '24 19:10 vifactor

@vifactor Are you able or did you already test this in an Online Logging use case?

alexmucde avatar Oct 23 '24 10:10 alexmucde

I have tried it with enabling and disabling this feature and it works, at least in the offline mode.

alexmucde avatar Oct 23 '24 10:10 alexmucde

I tried in offline too. I will check it in online a bit later

vifactor avatar Oct 23 '24 10:10 vifactor

online mode seem to work too: image

vifactor avatar Oct 24 '24 06:10 vifactor