dlt-viewer icon indicating copy to clipboard operation
dlt-viewer copied to clipboard

Reapply "Use QCommandLineParser instead of custom cmd args parsing (#543)"

Open vifactor opened this issue 1 year ago • 7 comments

PR employs QCommandLineParser for parsing cmd args for dlt-viewer. As requested, in a followup PRs similar change can be applied to other cli tools developed in this repo.

The PR restores the previously reverted changes, that reported to cause some issues. Should remain unmerged until fix is found (but only after clear issue is reported) or we can merge it again and if issue is observed, request to create a bug ticket with clear description.

@alexmucde I would need your help to understand what kind of issues this causes and how to reproduce it. Unit tests can help to ensure workability of different cmd scenarious.

vifactor avatar Oct 14 '24 20:10 vifactor

@vifactor I will test the version

alexmucde avatar Oct 17 '24 13:10 alexmucde

I have tried a first use case, which did not work: -c C:\traces\out.txt C:\traces\in.dlt -t The conversion to ASCII was not working.

alexmucde avatar Oct 18 '24 08:10 alexmucde

from the path I conclude that it is on Windows. Thanks @alexmucde ,I'll investigate from here

vifactor avatar Oct 18 '24 09:10 vifactor

I do not know what I do differently, but for me it just works on Windows too: image

vifactor avatar Oct 18 '24 19:10 vifactor

@vifactor I will try again.

alexmucde avatar Oct 23 '24 10:10 alexmucde

No it works also on my side. Do not know what i made wrong last time. I will test now further use cases.

alexmucde avatar Oct 23 '24 11:10 alexmucde

The use cases i have tested work now. Should we give it another try now and merge it?

alexmucde avatar Oct 23 '24 18:10 alexmucde

I would give it a try, yes. Quite confident thanks of unit tests, but of course platform-specific bugs are not excluded, so if there is an issue would be nice to have a nice bug report

vifactor avatar Oct 24 '24 06:10 vifactor

@vifactor Tested it now also in my productive system in Ubuntu 24.04 and works fine.

alexmucde avatar Oct 24 '24 08:10 alexmucde