dlt-viewer icon indicating copy to clipboard operation
dlt-viewer copied to clipboard

Revert "Revert Rename of dlt_common. (#512)"

Open LocutusOfBorg opened this issue 1 year ago • 9 comments

This reverts commit a3ad76c19cea1a52a8870d435e6cb4f1de4d2621.

LocutusOfBorg avatar Jul 30 '24 15:07 LocutusOfBorg

reopened

LocutusOfBorg avatar Jul 30 '24 15:07 LocutusOfBorg

Thanks, i reverted already with this PR #512

alexmucde avatar Jul 31 '24 05:07 alexmucde

So, can you please explain what broke? We should really convert it into a c++ file, if containing c++ code, right?

LocutusOfBorg avatar Jul 31 '24 06:07 LocutusOfBorg

@LocutusOfBorg Sorry i have not much tiem at the moment. The Windows build was not working, thats why i have reverted it. If you can also have a look into Windows would be nice.

alexmucde avatar Aug 14 '24 14:08 alexmucde

@alexmucde does the pipeline have some link? I don't have any windows machine, nor I know how to build, but if the pipeline runs on GitHub I can try to fix...

LocutusOfBorg avatar Aug 14 '24 22:08 LocutusOfBorg

@alexmucde can you please try this solution instead? It fixes the build for me

LocutusOfBorg avatar Sep 24 '24 09:09 LocutusOfBorg

@LocutusOfBorg I get the following error:

Bibliothek "..\release\qdlt.lib" und Objekt "..\release\qdlt.exp" werden erstellt. qdltoptmanager.obj : error LNK2019: Verweis auf nicht aufgel”stes externes Symbol "__imp_GetWindowThreadProcessId" in Funktion ""public: void __cdecl QDltOptManager::parse(class QStringList *)" (?parse@QDltOptManager@@QEAAXPEAVQStringList@@@Z)". ..\release\qdlt.dll : fatal error LNK1120: 1 nicht aufgel”ste Externe

alexmucde avatar Oct 14 '24 14:10 alexmucde

The following line is missing in qdlt.pro:

win32:LIBS += User32.lib

This is already integrated in the master.

alexmucde avatar Oct 14 '24 14:10 alexmucde

is it ok now? I did sync master

LocutusOfBorg avatar Oct 15 '24 12:10 LocutusOfBorg

@LocutusOfBorg Sorry, we have some conflicts now.

alexmucde avatar Dec 11 '24 14:12 alexmucde

Rebased, I admit after https://github.com/COVESA/dlt-viewer/pull/594 this is not useful anymore, but we can still simplify somewhere the speed_t definition in one single place, to have better code and more clean

LocutusOfBorg avatar Dec 12 '24 11:12 LocutusOfBorg

thanks!

LocutusOfBorg avatar Jan 25 '25 17:01 LocutusOfBorg