capicxx-dbus-runtime icon indicating copy to clipboard operation
capicxx-dbus-runtime copied to clipboard

Extend DBusObjectManager to use GetAll

Open thorsten-klein opened this issue 6 years ago • 3 comments
trafficstars

The DBusObjectManager is specified by freedesktop to return as each value in inner dict the same dict that would be returned by the org.freedesktop.DBus.Properties.GetAll() method for that combination of object path and interface. Only if an interface has no properties, an empty dict will be returned.

thorsten-klein avatar Nov 26 '18 17:11 thorsten-klein

Hello, do you have any timeline when this PR is going to be merged?

thorsten-klein avatar Jan 14 '19 16:01 thorsten-klein

Hello @gunnarx , do you know when this PR will be merged?

thorsten-klein avatar Mar 19 '19 12:03 thorsten-klein

@thorsten-klein First, thanks for the change proposal.

The project’s maintainer/developers seem to be busy with other things and not responding... so the short answer is unfortunately that I do not know... I will contact the maintainer again to find out what is going on, and what to expect here.

On the code, what you propose seems to make sense to me. If I understand correctly you are saying the current code is incorrect, if it intends to follow standard D-Bus conventions (as defined by freedesktop) and this should be considered a bug fix? If I felt more comfortable evaluating the possible impact of changing this behavior I could step in more actively, but I feel I don’t know the original design choices made in this part of the code.

If we don’t find a better solution would you be open to other options? Creating a branch/fork, or even that you step in to help out on maintenance of this repo? Do you expect to make/propose more changes?

gunnarx avatar Mar 25 '19 09:03 gunnarx