cosima-recipes icon indicating copy to clipboard operation
cosima-recipes copied to clipboard

Add sector-based sea ice analysis (#393)

Open serenaschroeter opened this issue 1 year ago • 21 comments

Code to calculate and visualise sector-based sea ice metrics for Southern Hemisphere based on sector definitions in Raphael & Hobbs, 2014. Obtains NSIDC observational estimate directly from PolarWatch, and uses COSIMA Cookbook to access model data.

Closes #393

serenaschroeter avatar Sep 16 '24 23:09 serenaschroeter

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

I updated the branch with changes that happened in main. You should pull the changes before you continue edit the notebook otherwise merge conflicts might created.

navidcy avatar Sep 16 '24 23:09 navidcy

Just noting that the experiment data referenced in this notebook appears to be available via access-nri-intake-catalog. That being said, it's probably best to bring the notebook in 'as is' (modulo any other changes), and convert it to intake later under #313 .

marc-white avatar Sep 17 '24 01:09 marc-white

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:23Z ----------------------------------------------------------------

We call them "recipes", not "scripts". Could you please rephrase? Also, define SIA in the text as well, at least the first time.


View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:24Z ----------------------------------------------------------------

Could you add a link to the reference? E.g., [Raphael & Hobbs (2014)](https://doi.org/XXXX.YYYY)


View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:24Z ----------------------------------------------------------------

Why we have numbers 71.? Either 71.0 if we need that or just 71?


View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:25Z ----------------------------------------------------------------

put this cell at the top


View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:26Z ----------------------------------------------------------------

Let's make a different step for the conversion, e.g.,

OM2_SIC = OM2_SIC.fillna(0)

OM2_SIC = OM2_SIC* 1.e-6 # convert m^2 -> km^2

(Also, not 1.e-6 since what does . add here?)


View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #6.    CDR_area = CDR_area / 1000

I don't understand why divide by 1000 here


anton-seaice commented on 2024-09-18T06:46:53Z ----------------------------------------------------------------

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

navidcy commented on 2024-10-04T04:44:53Z ----------------------------------------------------------------

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #23.    OM2_SIA_sectors = xr.DataArray(OM2_SIA_sectors,dims=["sector","time"],coords=[list(sectors.keys()),OM2_SIC.coords["time"].values])

here, as well as previous line add space after commas?


It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago


View entire conversation on ReviewNB

anton-seaice avatar Sep 18 '24 06:09 anton-seaice

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??


navidcy commented on 2024-10-04T04:45:14Z ----------------------------------------------------------------

What is a "glow up"?

edoddridge commented on 2024-12-10T00:17:35Z ----------------------------------------------------------------

A shiny transformation.

https://www.dictionary.com/e/pop-culture/glow-up/

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?


View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)


View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area


View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same


View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy avatar Sep 24 '24 00:09 navidcy

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy avatar Oct 04 '24 04:10 navidcy

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?


View entire conversation on ReviewNB

navidcy avatar Oct 04 '24 04:10 navidcy

What is a "glow up"?


View entire conversation on ReviewNB

navidcy avatar Oct 04 '24 04:10 navidcy