cosima-cookbook icon indicating copy to clipboard operation
cosima-cookbook copied to clipboard

Update instructions: nuke VDI and OOD; add ARE

Open navidcy opened this issue 2 years ago • 7 comments

This PR updates the instructions and removes all references to deprecated VDI system.

Closes #272 Closes #328

navidcy avatar Nov 20 '22 19:11 navidcy

What about ARE?

micaeljtoliveira avatar Nov 21 '22 00:11 micaeljtoliveira

ci/circleci: py36 — Your tests failed on CircleCI ?

navidcy avatar Nov 21 '22 21:11 navidcy

perhaps we wanna drop testing on python < 3.9?

navidcy avatar Nov 21 '22 21:11 navidcy

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.94%. Comparing base (a9f5fc9) to head (3730930).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   54.94%   54.94%           
=======================================
  Files          22       22           
  Lines        1811     1811           
=======================================
  Hits          995      995           
  Misses        816      816           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 28 '24 06:02 codecov[bot]

I believe this is ready for review again ;)

navidcy avatar Feb 28 '24 06:02 navidcy

@aekiss does this PR resolve #328? Should we add more details for ARE?

navidcy avatar Feb 28 '24 06:02 navidcy

Thanks! Looks good from here. I'll let Andrew respond to your question above, but otherwise I'm happy.

angus-g avatar Feb 28 '24 06:02 angus-g

I've redirected the Cookbook documentation to that for the Recipes (#340), so I don't think this applies any more. This will probably fade out of relevance with the introduction of the Intake catalogue anyway.

angus-g avatar Jul 01 '24 01:07 angus-g