CMSgov
Prevent automatic PRs from creating unwanted files
Describe the bug
In several recent automated PRs from the design system, it's included files I don't think are supposed to be part of the upgrade. It's attempted to create a new folder called client@tmp/durable-${sha} with the following files:
- jenkins-log.txt
- script.sh
- script.sh.copy
To Reproduce
I'm not able to re-create this on my own, but here are some examples:
- https://github.cms.gov/CMS-WDS/scout/pull/1301/files
- https://github.cms.gov/CMS-WDS/scout/pull/1237/files
- https://github.cms.gov/CMS-WDS/scout/pull/1227/files
Expected behavior
I expect the automated PRs to only contain changes that are expected to be part of the upgrade.
Additional context
I am guessing this automation is controlled by the design system - this could be a mistaken assumption.
We'll look into this. Looks like one of the shell scripts is for handling the upgrade. I think most folks do the upgrades manually, and don't end up using these pull requests, so we can maybe get rid of these files.
Thank you for taking a look!
We did end up doing them manually, as we had git conflicts due to other recent changes we made in the package-lock.json.
However, merging the automated PRs would mean permanently adding these files to the repo, meaning we'd have a new folder every time we merged an automated PR (due to the use of the sha in the directory's name). This would have prevented me from merging the automated PR even without the git conflict.