design-system icon indicating copy to clipboard operation
design-system copied to clipboard

[WNMGDS-2673] Deprecate scrollableNotice prop

Open zarahzachz opened this issue 11 months ago • 1 comments

WNMGDS-2673

The defaultProps for Table has an Alert component with specific text and CSS classes applied. Discussed with Patrick and it seems this was an over-optimization situation; Would be better to hard-code the styled Alert and provide a prop to overwrite the Alert text instead of the whole component.

Oh! Also, the default Alert wasn't translated and that needed to be done.

Todos:

  • Need official Spanish translation for Alert
  • Need guidance for how the Alert should appear on small breakpoints - is this pattern even useful/accessible as it references arrow keys?

zarahzachz avatar Feb 26 '24 21:02 zarahzachz

Are we scheduled to discuss this in any meetings?

pwolfert avatar Mar 08 '24 21:03 pwolfert

Are we scheduled to discuss this in any meetings?

Brought this work up with Tiffany in a11y meeting and learned the entire pattern of a scrollable table is inaccessible (WCAG SC 1.4.10) and we should defer users on small viewports to the stackable table pattern instead.

Stackable tables will need finessing as they aren't really responsive either (layout doesn't work on XS breakpoint).

More context in Slack.

zarahzachz avatar Mar 13 '24 14:03 zarahzachz

closing because we've decided to refactor tables instead of removing this singular prop

zarahzachz avatar Apr 03 '24 15:04 zarahzachz