design-system icon indicating copy to clipboard operation
design-system copied to clipboard

[LHDM-2201] Header/Footer Custom classes/IDs

Open seesleestak opened this issue 1 year ago • 2 comments

Summary

  • Our team has a specific Smartling-related requirement to be able to assign class names and IDs to the logo, language switch link, and log in link in the Header and the logo in the Footer.
  • https://jira.cms.gov/browse/LHDM-2201

Update: After chatting, this has been simplified to only include the custom classes.

How to test

Use the story controls to apply the various new props. (Note that you'll have to use both the logged in and logged out stories to see all the props.)

Checklist

  • [x] Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • [x] Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • [x] Selected appropriate Impacts, multiple can be selected.
  • [x] Selected appropriate release milestone

If this is a change to design:

  • [ ] If visual regression image references have been changed, design MUST be assigned to review. In this instance, designer approval is a requirement before the PR can be merged.

If this is a change to code:

  • [x] Created or updated unit tests to cover any new or modified code
  • [x] If necessary, updated unit-test snapshots (yarn test:unit:update) and browser-test snapshots (yarn test:browser:update)

If this is a change to documentation:

  • [x] Checked for spelling and grammatical errors

seesleestak avatar Dec 29 '23 20:12 seesleestak

I ran yarn test:browser:update but the changes I saw locally didn't seem related to the PR changes or the build error. Any help deciphering that would be appreciated.

seesleestak avatar Dec 29 '23 22:12 seesleestak

@zarahzachz, can you review this now that I've made changes?

pwolfert avatar Jun 28 '24 23:06 pwolfert