design-system icon indicating copy to clipboard operation
design-system copied to clipboard

[LHDM-1818] Pass backdropClickExits to NativeDialog from Drawer

Open seesleestak opened this issue 2 years ago • 3 comments

Summary

  • Passing backdropClickExits to NativeDialog from Drawer to allow usage of the prop from Drawer/HelpDrawer. These changes are to support requests from stakeholders to implement a drawer similar to Medicare.gov's (with its modified functionality). Our team has currently patched in this change in order to move ahead with that implementation.
  • https://jira.cms.gov/browse/LHDM-1818

How to test

  1. yarn storybook
  2. Value for backdropClickExits and hasFocusTrap props allows the behavior in the Drawer example.

Checklist

  • [x] Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • [x] Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • [x] Selected appropriate Impacts, multiple can be selected.

If this is a change to code:

  • [ ] Created or updated unit tests to cover any new or modified code
  • [x] If necessary, updated unit-test snapshots (yarn test:unit:update) and browser-test snapshots (yarn test:browser:update)

If this is a change to documentation:

  • [x] Checked for spelling and grammatical errors

seesleestak avatar Jul 13 '23 15:07 seesleestak

@pwolfert Just wanted to bump this PR for possible inclusion in v12. Having this change would allow us to remove one of our patches.

seesleestak avatar Aug 24 '23 16:08 seesleestak

@seesleestak, I know the patches aren't a pretty thing, but we're not yet ready to merge this until we get a final word about the pattern from our stakeholders. We'll continue to discuss this.

pwolfert avatar Aug 24 '23 21:08 pwolfert

Understood, thanks for the update

seesleestak avatar Aug 24 '23 22:08 seesleestak

Hey there, I wanted to follow up on this change. Has any determination been made about it?

seesleestak avatar Mar 12 '24 16:03 seesleestak

👀 Thanks for making the required storybook updates 👍 Is this able to be merged whenever or do you need me to hold off?

seesleestak avatar Apr 09 '24 17:04 seesleestak

Go ahead and merge it, @seesleestak! You're clear to launch.

pwolfert avatar Apr 09 '24 17:04 pwolfert