bcda-app icon indicating copy to clipboard operation
bcda-app copied to clipboard

BCDA-8083: Skip failed terminal status when processing que_jobs

Open kyeah opened this issue 9 months ago • 0 comments

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8083

🛠 Changes

  • Skip que_job processing when parent job is marked as failed

ℹ️ Context for reviewers

Currently, que jobs are still processed even when the parent job has been marked as failed. This is unnecessary since failed jobs do not return any data from the Job/Jobs Status endpoints.

Note that this will impact job_count, completed_job_count, and the number of child job_keys (i.e. since we are short-circuiting this process, the numbers overall will be reduced for the failed parent job.) However, I have quickly checked that this will not impact any logic related to those values.

✅ Acceptance Validation

  • Unit Testing

🔒 Security Implications

  • [ ] This PR adds a new software dependency or dependencies.
  • [ ] This PR modifies or invalidates one or more of our security controls.
  • [ ] This PR stores or transmits data that was not stored or transmitted before.
  • [ ] This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

kyeah avatar May 16 '24 15:05 kyeah