CMCDragonkai
CMCDragonkai
Need to prove all of these cases with tests. 1. There needs to be tests that prove that the sensitive works and completely removes all sensitive information from errors passed...
Well in terms of filtering, we have to decide whether it is more explicit, in the sense of filtering a specific path in a structure, or filtering based on patterns....
Note the usage of `fs.cp` and the filter option. This uses a new utility `utils.pathIncludes` that I got from https://stackoverflow.com/a/45242825/582917 but tuned it to mean "does path 1 include path...
@joshuakarp @tegefaulkes @scottmmorris @emmacasolin comments?
Note the error when renaming a directory into an existing directory with stuff: ``` > fs.renameSync('./blah', './blah2') Uncaught Error: ENOTEMPTY: directory not empty, rename './blah' -> './blah2' at Object.renameSync (fs.js:794:3)...
Note that I'm not using `/tmp` or `mkdtemp` because I cannot trust that `/tmp` is secure and is on the same filesystem thus losing some atomicity guarantees. In this case...
Backup and Restore specced out here: #288. It seems both of these issues should be worked out by 1 implementation.
One issue with using `.polykey/state` is that what manages that specific path. One can imagine that `Schema`'s job is to create that `statePath`. Because the `PolykeyAgent` uses `Schema` to build...
If you clone a vault `vault` and `vault` already exists, then you'd get `vault-copy`. If there was a `vault-copy` then it would be `vault-copy-copy`. I'm looking at something similar to...
@amydevs in the future can you reduce the size of the circles, makes it hard to see in the issue review.