edbrowse icon indicating copy to clipboard operation
edbrowse copied to clipboard

stop using readline.h

Open kyx0r opened this issue 2 years ago • 3 comments

At least mention that it's required or even better vendor it.

kyx0r avatar May 17 '22 14:05 kyx0r

I would not recommend vendoring a common library like readline; it should be available in any distribution and if edbrowse is packaged in such a distribution the packagers would want to use their readline, not a potentially out of date bundled version.

But mentioning all requirements in the documentation is a good idea, and making the use of readline optional is a reasonable request.

ryandesign avatar Jun 21 '22 03:06 ryandesign

I would not recommend vendoring a common library like readline;

I don't know what this means. Sorry I'm not a packager. Do we "vendor" readline? It's just a library we link to, like libc or libm or libpcre2 etc.

Karl Dahlke

eklhad avatar Oct 11 '22 06:10 eklhad

"vendoring" would mean including all readline sources inside the edbrowse repository and building it together with edbrowse. We do not do that (and there shouldn't be any reason to ever do that), just mentioning it as a requirement in the README should be good enough.

martinetd avatar Oct 11 '22 07:10 martinetd