CLI11 icon indicating copy to clipboard operation
CLI11 copied to clipboard

UWP broken by Unicode support in 2.4

Open henryiii opened this issue 1 year ago • 1 comments

The UWP tests in vcpackage are reporting:

C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe   /TP -DCLI11_COMPILE -ID:\b\cli11\src\v2.4.0-2775f05bcd.clean\include /DWIN32 /D_WINDOWS /D_UNICODE /DUNICODE /DWINAPI_FAMILY=WINAPI_FAMILY_APP /D__WRL_NO_DEFAULT_LIB__ /nologo /Z7 /MP /GS /Gd /Gm- /W3 /WX- /Zc:wchar_t /Zc:inline /Zc:forScope /fp:precise /Oy- /EHsc  /utf-8  /D_DEBUG /MDd /Od /RTC1  -MDd /showIncludes /Fosrc\CMakeFiles\CLI11.dir\Precompile.cpp.obj /Fdsrc\CMakeFiles\CLI11.dir\CLI11.pdb /FS -c D:\b\cli11\src\v2.4.0-2775f05bcd.clean\src\Precompile.cpp
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(69): error C3861: 'CommandLineToArgvW': identifier not found
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(72): error C3536: 'wargv': cannot be used before it is initialized
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(72): error C2446: '==': no conversion from 'nullptr' to 'int'
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(72): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(78): error C2109: subscript requires array or pointer type

See https://github.com/microsoft/vcpkg/pull/36589#issuecomment-1927128232.

henryiii avatar Feb 05 '24 15:02 henryiii

As far as I can tell, Microsoft has deprecated UWP a few years ago (https://www.thurrott.com/dev/258377/microsoft-officially-deprecates-uwp), and I'm not sure a CLI interface makes much sense in a UWP app anyway. So I think the best course of action might be to disable UWP in vcpkg.

henryiii avatar Feb 05 '24 15:02 henryiii