grlc icon indicating copy to clipboard operation
grlc copied to clipboard

Unexpected warning if no endpoint specified,

Open ecow opened this issue 4 years ago • 4 comments

I think that to use the default endpoint should be perfectly legal, so probably the warning:

WARNING:No endpoint specified, using default

could be removed

ecow avatar Jul 19 '21 18:07 ecow

True. Perhaps it is useful in debugging mode...

c-martinez avatar Jul 23 '21 06:07 c-martinez

yes, it could be useful in debugging . I close the issue

ecow avatar Jul 23 '21 15:07 ecow

I reopen this issue because looking to the code, it seams to me that in line 63 of src/gquery.py the line:

glogger.warning("No endpoint specified, using default ({})".format(endpoint))

could be rewitten as

glogger.info("No endpoint specified, using default ({})".format(endpoint))

In my opinion, Info is most appropriate level for this kind of log, also looking to similar cases in the same function.

Anyway it is just a very minor issue.

ecow avatar Aug 04 '21 09:08 ecow

Thanks -- added that one to pending PR #355 on commit 6c2cf0a so it should all be merged together :-)

c-martinez avatar Aug 13 '21 06:08 c-martinez