SublimeDiffView icon indicating copy to clipboard operation
SublimeDiffView copied to clipboard

Preview not closed when starting in 2-column view

Open CJTozer opened this issue 9 years ago • 4 comments

Put the editor in 2-column view, then try a diff.

After pressing esc to finish, the LHS preview is still there.

CJTozer avatar Dec 19 '15 23:12 CJTozer

This is a bit tricky, as there doesn't seem to be any good way to work out if open_file is really creating a new file, or just focussing on an existing one.

In the latter case, if we blindly close the 'previews' then we could close a view that was genuinely there before the diff...

window.find_open_file() only returns one file, not the possible set (in different views).

CJTozer avatar Dec 22 '15 22:12 CJTozer

Ok, I can't see a quick fix for this, so let's push out of v1.0.0. If there are people clamouring for this fix I'll revisit, otherwise just on the backlog.

CJTozer avatar Jan 02 '16 23:01 CJTozer

I submitted an issue, which is probably connected to this: https://github.com/CJTozer/SublimeDiffView/issues/55

I am demonstrating the problem with a two-column view, but even with a single-column view the diff previews are still not closing after pressing escape .

Nikaoto avatar Jan 28 '18 23:01 Nikaoto

Thanks for the report - I'll try to take another look at this. Perhaps the ST3 APIs have improved, or I'll come up with a good enough workaround.

CJTozer avatar Jan 29 '18 10:01 CJTozer