microservice_framework_version_6 icon indicating copy to clipboard operation
microservice_framework_version_6 copied to clipboard

Published 20 hours ago • verified publisher icon CJSCommonPlatform

messaging-adapter-core and rest-adapter-core should depend on api not on core

Open jaceko opened this issue 7 years ago • 1 comments

Currently messaging-adapter-core and rest-adapter-core depend on the implementation module (core) rather than api. We shuld break this dependency and depend on api. The prerequisite for this task is: https://github.com/CJSCommonPlatform/microservice_framework/issues/407

jaceko avatar Jul 25 '17 13:07 jaceko

I doesn't seem as simple as removing core dependencies and adding framework-api-core in the two modules. The following classes will become broken: JsonSchemaValidationInterceptor.java JsonValidationLoggerHelper.java DefaultJmsProcessor.java

After a discussion we've come to the following steps to achieve this:

  1. uk.gov.justice.services.adapter.messaging.DefaultJmsProcessor - use SPI approach (using static method in interface) - will be done as a start in a separate pull request.

  2. uk.gov.justice.services.core.mapping.NameToMediaTypeConverter - make an interface in API and implement in core (keeping same packaging)

  3. Create a custom Exception in API replacing ValidationException used in JsonSchemaValidationInterceptor and JsonValidationLoggerHelper

artur-synowiec avatar Jan 24 '18 14:01 artur-synowiec