Ryan Johnson comments

Results 80 comments of


                                            Ryan Johnson

Menu does not close after selecting an option

We'll be looking into refactoring how `` and `` behave as part of a future update.

Reduce CSS specificity for Link Styles

After a brief attempt, I discovered that `:link:visited` is not equivalent to `a:visited`. Will need to investigate further.

[FEATURE] Deep module imports

Anticipated consumption after Nov 2018 CAREaTHON project. ```javascript import { HXElement } from 'helix-ui/lib/elements'; import { KEYS } from 'helix-ui/lib/utils'; import { getPosition } from 'helix-ui/lib/utils/position'; ```

[FEATURE] Deep module imports

We'll be investigating LOE to complete this work.

Rendering error in rules document

@maxdeepfield: those two blank lines are part of the `✗ avoid` example. It should look like the following (2 blank lines between last two statements) ```javascript // ✓ ok var...

Typo in ESDoc's doc

This seems to have been fixed in #507

@emits is ignored within the class description

I'm working on getting this updated. * esdoc PR: #524 * esdoc-plugins PR: TBD

Introduce Class generic

ES6 classes are just syntactic sugar on top of classic constructor functions. What you probably want is: ```javascript class CarBuilder { /** * @param {function} carConstructor - class definition/constructor of...

Using esm breaks null coalescing operator

Have there been any updates to this? Any idea when this might be fixed?

Optional "tags" property on tokens

I agree with concatenating `$tags` as you walk down the JSON tree. This definition... ```json5 { "color": { "$tags": ["global"], "brand": { "$tags": ["marketing", "company"], "primary": { "400": { "$value":...