AIL-framework icon indicating copy to clipboard operation
AIL-framework copied to clipboard

Published 20 hours ago • verified publisher icon CIRCL

LUHN check on credit cards

Open syloktools opened this issue 5 years ago • 3 comments

Can a luhn check be added to validate credit card numbers?

https://pypi.org/project/fast-luhn/

syloktools avatar Dec 23 '19 13:12 syloktools

I thought we do it there https://github.com/CIRCL/AIL-framework/blob/ecd14b91d95af3960c56719a8227ffc5ddd5e4ff/bin/CreditCards.py#L68

Do you have any specific issues?

adulau avatar Dec 23 '19 14:12 adulau

I have seen some invalid card such as 4777777777777777

syloktools avatar Dec 23 '19 19:12 syloktools

Hi @robertnixon2003 !

I did some test and didn't find any issue with your Luhn implementation, 4777777777777777 is not detected as a valid credit-card

Can you share a sample of one of your false positive ?

Terrtia avatar Jan 09 '20 10:01 Terrtia