REDCapTidieR icon indicating copy to clipboard operation
REDCapTidieR copied to clipboard

[FEATURE] Update Default guess_max Arg to Inf

Open rsh52 opened this issue 1 year ago • 0 comments

Feature Request Description

After implementing the guess_max argument in #144, a default setting was applied as .Machine$integer.max. Instead, we want the default to be Inf.

This is currently blocked by the CRAN REDCapR v1.1.0 use of assert_integerish:

https://github.com/OuhscBbmc/REDCapR/blob/efd8a749ffb6333a6856fb195e7de5bb4b9b8b26/R/redcap-read-oneshot.R#L214

It seems like the latest dev version has dropped this assertion. Once it's on CRAN, we should update here as well.

Additional Context

Summary: Update default guess_max to Inf with next release of REDCapR.

Checklist

  • [x] The issue is atomic
  • [x] The issue description is documented
  • [x] The issue title describes the problem succinctly
  • [x] Developers are assigned to the issue
  • [x] Labels are assigned to the issue

rsh52 avatar Apr 03 '23 20:04 rsh52